[Refactor] Collapse sleep-check cancel-vs-fail finalization#69
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Refactor] Collapse sleep-check cancel-vs-fail finalization#69roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Extract finalizeSweptJob so timed and heartbeat recovery paths share one cancel-vs-fail finish/record/log path instead of copying branches.
Contributor
Author
|
1 issue outstanding. See task
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Sleep-check recovery paths that finalize a swept job as canceled or failed no longer each inline the same status resolution, event recording, logging, and
finishCloudJobsequence. Those branches now call a sharedfinalizeSweptJobhelper and only supply path-specific messages and details.Why this change was made
After the canceled-task recovery work in #53, timed and heartbeat recovery paths still duplicated nearly identical cancel-vs-fail finalization blocks in an already large scheduled job. The next recovery path would have copied that third branch again.
Impact
No intentional user-facing behavior change. Canceled vs failed status selection, sleep-check events, and finish arguments stay the same; the scheduled job is easier to extend without another copy-paste when a new sweep recovery path is added.